Re: [PATCH] gnu: Add tcllib.

[Pjotr Prins]

To all. 

Again, I think we have to be more careful with new committers. All
comments below are in the trivial category (in my opinion).

I appreciate the work reviewers are doing (thank you!), but we should
take care to be nice and welcoming so as not to lose people. I
personally think that the focus on spacing and indentation is way over
the top.  Especially when you realise many packages in the tree are
not up to current standards. Anyone looked at python.scm?

Can we concentrate on functionality first. And when a package is
pretty much up to scratch just do the final editing by the actual
committer?

Ricardo give a great example here, he corrects and tells us. That way
we learn in a nice way. Submitting packages and abiding by all the
rules is not trivial. Not to mention that lint is sometimes broken and
there are many packages in the tree that do *not* abide by current
rules. I go wrong when I copy something already there. It is not that
easy.

We need to find a balance between being nice and being correct.

And don't forget: thank you Jan for the contributions :). Please
continue! We welcome you.

Pj.

On Thu, Feb 11, 2016 at 09:53:47PM +0200, Efraim Flashner wrote:
> On Tue, 09 Feb 2016 21:19:35 +0100
> Jan Nieuwenhuizen <address@hidden> wrote:
> 
> > From: Jan Nieuwenhuizen <address@hidden>
> > To: address@hidden
> > Subject: [PATCH] gnu: Add tcllib.
> > Date: Tue, 09 Feb 2016 21:19:35 +0100
> > Sender: address@hidden
> > User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
> > Organization: AvatarAcademy.nl
> > 
> > Hi,
> > 
> > A "new" package.
> > 
> > Greetings, Jan
> > 
> > 
> > From 51f0b17b38385197240bca37b290730b2fbe5df1 Mon Sep 17 00:00:00 2001
> > From: Jan Nieuwenhuizen <address@hidden>
> > Date: Tue, 9 Feb 2016 20:44:59 +0100
> > Subject: [PATCH] gnu: Add tcllib.
> > 
> >     * gnu/packages/tcl.scm (tcllib): New variable.
> > ---
> >  gnu/packages/tcl.scm | 31 +++++++++++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> > 
> > diff --git a/gnu/packages/tcl.scm b/gnu/packages/tcl.scm
> > index 2c4c750..8d6059d 100644
> > --- a/gnu/packages/tcl.scm
> > +++ b/gnu/packages/tcl.scm
> > @@ -3,6 +3,7 @@
> >  ;;; Copyright © 2014, 2015 Mark H Weaver <address@hidden>
> >  ;;; Copyright © 2014 Eric Bavier <address@hidden>
> >  ;;; Copyright © 2016 Efraim Flashner <address@hidden>
> > +;;; Copyright © 2016 Jan Nieuwenhuizen <address@hidden>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -219,3 +220,33 @@ interfaces (GUIs) in the Tcl language.")
> >      ;; pTk/license.terms, pTk/license.html_lib, and pTk/Tix.license for
> >      ;; details of this license."
> >      (license (package-license perl))))
> > +
> > +(define-public tcllib
> > +  (package
> > +    (name "tcllib")
> > +    (version "1.18")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append "mirror://sourceforge/" name "/"
> > +                                  name "-" version ".tar.gz"))
> > +              (sha256
> > +               (base32
> > +                "05dmrk9qsryah2n17z6z85dj9l9lfyvnsd7faw0p9bs1pp5pwrkj"))))
> > +    (build-system gnu-build-system)
> > +    (native-inputs
> > +     `(("tcl" ,tcl)))
> > +    (native-search-paths
> > +     (list (search-path-specification
> I don't think this needs to be a list. Also, it should be indented 2 spaces
> (I believe)
> 
> > +       (variable "TCLLIBPATH")
> > +       (separator " ")
> > +       (files (list (string-append "lib/tcllib" version ""))))))
> why the double quote after version?
> 
> > +    (home-page "https://core.tcl.tk/tcllib/home";)
> > +    (synopsis "Standard Tcl Library")
> > +    (description "Tcllib, the standard Tcl library, is a collection of 
> > common utility
> utility should be on the next line
> 
> > + functions and modules all written in high-level Tcl.
> > +")
> the ") should be on the previous line
> 
> > +    (license (non-copyleft "http://www.tcl.tk/software/tcltk/license.html";
> > +                      "Tcl/Tk license"))))
> I can't find it on the FSF list 
> (https://www.gnu.org/licenses/license-list.html), 
> but according to https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing,
> the Tcl license is a FSF approved license, so another patch before this one
> to add it to the license list would be good. It's possible that I'm wrong, so
> if someone else can check me that'd be good.
> 
> > +
> > +
> > +
> you don't need all these extra spaces
> 
> 
> -- 
> Efraim Flashner   <address@hidden>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted



--