Re: [PATCH] gnu: Add slurm.

[Pjotr Prins]

On Sat, Feb 13, 2016 at 11:28:25AM +0100, Andreas Enge wrote:
> Some lines are way beyond 80 characters; this should be detected by
> "guix lint".

guix lint has not been working for me:

./pre-inst-env guix lint slurm
warning: failed to install locale: Invalid argument
filtered-port: failed to execute ' -dc ': No such file or directory
Backtrace:
In unknown file:
   ?: 19 [apply-smob/1 #<catch-closure 243f940>]
In ice-9/boot-9.scm:
  63: 18 [call-with-prompt prompt0 ...]
In ice-9/eval.scm:
 432: 17 [eval # #]
In ice-9/boot-9.scm:
(...)
In guix/utils.scm:
 255: 5 [call-with-decompressed-port gzip ...]
In guix/cve.scm:
 143: 4 [#<procedure 3552980 at guix/cve.scm:139:3 (port)> #<closed: file 0>]
 133: 3 [xml->vulnerabilities #<closed: file 0>]
In ice-9/boot-9.scm:
 105: 2 [#<procedure 23d1180 at ice-9/boot-9.scm:97:6 (thrown-k . args)> 
parser-error ...]
  65: 1 [abort-to-prompt catch7 parser-error ...]
In unknown file:
   ?: 0 [scm-error misc-error #f "~A ~S" ("decompressed-port failure" (6495)) 
#f]

ERROR: In procedure scm-error:
ERROR: decompressed-port failure (6495)

any idea what this could be?

> However, your patch still does not apply on top of master:
> Applying: gnu: Add slurm.
> .git/rebase-apply/patch:87: trailing whitespace.
>                  (substitute* "./doc/html/shtml2html.py" 
> .git/rebase-apply/patch:119: space before tab in indent.
>                  config.xml
> .git/rebase-apply/patch:120: space before tab in indent.
>                  auxdir/Makefile
> .git/rebase-apply/patch:141: space before tab in indent.
>                  doc/Makefile
> .git/rebase-apply/patch:142: space before tab in indent.
>                  doc/man/Makefile
> error: patch failed: gnu/packages/parallel.scm:2
> error: gnu/packages/parallel.scm: patch does not apply
> Patch failed at 0001 gnu: Add slurm.
> 
> I do not think that the whitespace is a real issue; did you rebase before
> sending the patch? It is quite curious since the parallel.scm file has not
> been changed yet this year.

I am using a recent repo of guix. I did do a rebase and the patch applies
on my tree (as did the previous one). Is there no more information?

Pj.

--