Re: [PATCH] gnu: Add slurm.

[Pjotr Prins]

OK, patch coming up.

On Sat, Feb 13, 2016 at 11:28:25AM +0100, Andreas Enge wrote:
> On Sat, Feb 13, 2016 at 09:59:40AM +0100, Pjotr Prins wrote:
> > Another package name (this time we go down to slurm), another patch.
> 
> Actually, the name of the patch file: slurm-wml-....patch should also
> be changed... And it needs to be registered in gnu-system.am.
> 
> Some lines are way beyond 80 characters; this should be detected by
> "guix lint".

Only one line that I can tell

  (patches (list (search-patch 
"slurm-wlm-configure-remove-nonfree-contribs.patch")))

> > I also put the modules in alphabetic order when adding the license
> > name space. Hope that doesn't need a separate patch.
> 
> I think that is fine.
> 
> However, your patch still does not apply on top of master:
> Applying: gnu: Add slurm.
> .git/rebase-apply/patch:87: trailing whitespace.
>                  (substitute* "./doc/html/shtml2html.py" 
> .git/rebase-apply/patch:119: space before tab in indent.
>                  config.xml
> .git/rebase-apply/patch:120: space before tab in indent.
>                  auxdir/Makefile
> .git/rebase-apply/patch:141: space before tab in indent.
>                  doc/Makefile
> .git/rebase-apply/patch:142: space before tab in indent.
>                  doc/man/Makefile
> error: patch failed: gnu/packages/parallel.scm:2
> error: gnu/packages/parallel.scm: patch does not apply
> Patch failed at 0001 gnu: Add slurm.
> 
> I do not think that the whitespace is a real issue; did you rebase before
> sending the patch? It is quite curious since the parallel.scm file has not
> been changed yet this year.

I double checked. There is no tabs or trailing whitespace in the
package.

Anyway try again. If it fails I give up. I have had enough of slurm
and for now of sending patches back and forth.

Pj.