guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnu: Add python-wtforms.


From: Christopher Allan Webber
Subject: Re: gnu: Add python-wtforms.
Date: Sat, 13 Feb 2016 15:07:17 -0800
User-agent: mu4e 0.9.13; emacs 24.5.1

Christopher Allan Webber writes:

> Leo Famulari writes:
>
>> On Sat, Feb 13, 2016 at 01:55:01PM -0800, Christopher Allan Webber wrote:
>>> Christopher Allan Webber writes:
>>
>> [...]
>>
>>> >>> * gnu/packages/python.scm (python-wtforms, python2-wtforms): New 
>>> >>> variables.
>>> >>
>>> >> It looks good to me, but I wonder if the python-3 variant really needs
>>> >> setuptools? If so, okay. If not, can you use the new python2-variant
>>> >> system [0] to provide setuptools for python2-wtforms?
>>> >>
>>> >> [0] Introduced in 48b311b1b3ba
>>> >
>>> > Okay, I'll give that a try, and will make an adjustment if appropriate,
>>> > and regardless, push after figuring that out.
>>> >
>>> > Thanks to both of you!
>>> 
>>> Well, I think it's significant enough of a change where I should get
>>> some validation that everything looks right before I push.  New version,
>>> ahoy!  Is it ok?
>>
>> I believe that you still must call 'package-with-python2' in the
>> python-2 variant, and the argument to that should be
>> (strip-python2-variant python-foo).
>>
>> I've attached an example commit that seems to work, from one of my WIP
>> branches.
>
> Ah, you're right!  New patch!
>
>  - Chris

Leo also pointed out that the (name) redefinition might not be needed,
and indeed it wasn't!

And with that, pushed.  Whew!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]