Re: Inherit inputs when unnecessary in these python2 packages?

[Leo Famulari]

On Sun, Feb 14, 2016 at 03:48:32PM +0100, Andreas Enge wrote:
> On Sat, Feb 13, 2016 at 06:10:17PM -0800, Christopher Allan Webber wrote:
> > >     (native-inputs
> > >      `(("python-setuptools-scm" ,python-setuptools-scm)))
> > > 
> > > (define-public python2-execnet
> > >   (package
> > >     (inherit (package-with-python2
> > >               (strip-python2-variant python-execnet)))
> > >     (inputs
> > >      `(("python2-setuptools" ,python2-setuptools)))))
> > 
> > As you can see, there is no inputs on python-execnet, so it's not
> > necessary to include the inputs.  However, if (inputs) were added in the
> > future, this could lead to a developer mistakenly forgetting to change
> > the python2 variant.
> 
> This looks suspicious; should the python2-setuptools not also be a
> native input? Then accidentally the problem you mention would also
> disappear.

Yes, I pointed this out to Christopher after missing it in my review. It
should be fixed at some point.