Re: [PATCH 3/3] gnu: Add vcsh

[Christopher Baines]

On 13/02/16 22:41, Leo Famulari wrote:
> On Sat, Feb 13, 2016 at 04:07:55PM +0000, Christopher Baines wrote:
>> * gnu/packages/version-control.scm (vcsh): New variable.
> 
> [...]
> 
>> +    (arguments
>> +     `(#:phases (modify-phases %standard-phases
>> +                  (delete 'configure)
>> +                  (delete 'check)
>> +                  (delete 'build))
> 
> Can you add comments explaining why the check and build phases are
> deleted?

Yep, I have attached an updated patch.

> For the former, it can be as simple as "no test suite".

There actually is one, I just forgot to enable it. This is now fixed in
the attached patch.

> I assume the build phase is replaced by the install phase; the comment
> can say something like that if it's the case.

Done.

0003-gnu-Add-vcsh.patch
Description: Text Data

signature.asc
Description: OpenPGP digital signature