Re: [PATCH 11/18] gnu: Add python-webtest.

[Christopher Allan Webber]

Leo Famulari writes:

> On Mon, Feb 15, 2016 at 03:31:40PM -0800, Christopher Allan Webber wrote:
>> From 562f8e028563ac3eebe6c90b1c9e4bb3bc379177 Mon Sep 17 00:00:00 2001
>> From: Christopher Allan Webber <address@hidden>
>> Date: Sat, 13 Feb 2016 22:13:14 -0800
>> Subject: [PATCH 11/18] gnu: Add python-webtest.
>> 
>> * gnu/packages/python.scm (python-webtest, python2-webtest):
>>   New variables.
>> ---
>>  gnu/packages/python.scm | 50 
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 50 insertions(+)
>> 
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index 1238849..f5015df 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -7806,3 +7806,53 @@ pyquery uses lxml for fast xml and html 
>> manipulation.")
>>        (inherit pyquery)
>>        (inputs `(("python2-setuptools" ,python2-setuptools)
>>                  ,@(package-inputs pyquery))))))
>> +
>> +(define-public python-webtest
>> +  (package
>> +    (name "python-webtest")
>> +    (version "2.0.20")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "WebTest" version))
>> +       (sha256
>> +        (base32
>> +         "0bv0qhdjakdsdgj4sk21gnpp8xp8bga4x03p6gjb83ihrsb7n4xv"))))
>> +    (build-system python-build-system)
>> +    (arguments
>> +     `(;; Unfortunately we have to disable tests!
>> +       ;; This release of WebTest is pinned to python-nose < 1.3,
>> +       ;; but older versions of python-nose are plagged with the following
>
> s/plagged/plagued

Fixed

>> +    (inputs
>> +     `(("python-waitress" ,python-waitress)
>> +       ("python-webob" ,python-webob)
>> +       ("python-six" ,python-six)
>> +       ("python-beautifulsoup4" ,python-beautifulsoup4)))
>> +    (home-page "http://webtest.pythonpaste.org/";)
>> +    (synopsis "Helper to test WSGI applications")
>> +    (description "Helper to test WSGI applications")
>
> The description should at least be a complete sentence, and ideally
> offer more detail than the synopsis.

Fixed

>> +    (license license:expat)
>> +    (properties `((python2-variant . ,(delay python2-webtest))))))
>> +
>> +(define-public python2-webtest
>> +  (let ((webtest (package-with-python2
>> +                  (strip-python2-variant python-webtest))))
>> +    (package
>> +      (inherit webtest)
>> +      (inputs `(("python2-setuptools" ,python2-setuptools)
>> +                ,@(package-inputs webtest))))))
>> -- 
>> 2.6.3
>> 
>>