guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add libBigWig.


From: Leo Famulari
Subject: Re: [PATCH] gnu: Add libBigWig.
Date: Wed, 24 Feb 2016 20:47:02 -0500
User-agent: Mutt/1.5.24 (2015-08-30)

On Wed, Feb 24, 2016 at 05:21:47PM +0100, Ricardo Wurmus wrote:
> Hi Guix,
> 
> the description is a little short.  Basically, this is a cleaner
> reimplementation of a popular tool/library that is released under a
> non-commercial license.  There is little more I can say about it and the
> original description just references that other tool.
> 
> Any ideas how to improve this?

If you think it will be clear to the intended audience, I'd say it's
fine.

If "Kent's library" is well-known in the field, would it make sense to
refer to it?

> +         (add-before 'install 'create-target-dirs
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (mkdir-p (string-append out "/lib"))
> +               (mkdir-p (string-append out "/include"))
> +               #t))))))

Does it make sense to upstream this? I understand if it's not worth your
time...



reply via email to

[Prev in Thread] Current Thread [Next in Thread]