guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] gnu: Add python-pastescript.


From: Christopher Allan Webber
Subject: Re: [PATCH 2/2] gnu: Add python-pastescript.
Date: Thu, 25 Feb 2016 11:03:35 -0800
User-agent: mu4e 0.9.13; emacs 24.5.1

Leo Famulari writes:

> On Tue, Feb 23, 2016 at 12:03:11PM -0800, Christopher Allan Webber wrote:
>> * gnu/packages/python.scm (python-pastescript, python2-pastescript):
>>   New variables.
>
> [...]
>
>> +     '(;; Unfortunately, this requires the latest unittest2,
>> +       ;; but that requires traceback2 which requires linecache2 which 
>> requires
>> +       ;; unittest2.  So we're skipping tests for now.
>> +       ;; (Note: Apparently linetest2 only needs unittest2 for its tests,
>> +       ;; so in theory we could get around this situation somehow.) 
>                                                                       ^
> Trailing white space -------------------------------------------------|

Oops!  Thanks.  (I should use whitespace-mode more often!)

>> +       #:tests? #f))
>> +    (synopsis
>> +     "Pluggable command line tool for serving web applications and more")
>> +    (description
>> +     "PasteScript is an extensible  command line tool which provides a 
>> variety
>> +of features, from launching web applications to bootstrapping project 
>> layouts.")
>
> The first half of this sentence applies to most command-line tools ;)
>
> Otherwise okay!

Fixed to be a bit more clear that "extensible" here refers to "plugins".

Thanks for the review.  Made those changes and pushed!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]