[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: xfce: Don’t wrap startxfce4.
|
From: |
宋文武 |
|
Subject: |
Re: [PATCH] gnu: xfce: Don’t wrap startxfce4. |
|
Date: |
Wed, 02 Mar 2016 08:33:17 +0800 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> address@hidden (宋文武) skribis:
>
> [...]
>>
>> This package was introduced before the ‘etc/profile’ where enviroment
>> variables from search-paths are set. So, the wrapper is redundant now.
>
> The wrapper would still be useful when it’s not installed in a profile
> (for instance, when running $(guix build xfce4)/bin/startxfce4), but
> that’s probably not a use case worth supporting in this case.
> Thoughts?
I guess so, in that way other packages aren't in PATH.
>
>> From 6f6ba4e8c347770b279e9344ba49bf305cd41da8 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <address@hidden>
>> Date: Mon, 29 Feb 2016 14:57:56 +0800
>> Subject: [PATCH] gnu: xfce: Don't wrap 'startxfce4'.
>>
>> The necessary environment variables are set by 'etc/profile' now.
>>
>> * gnu/packages/xfce.scm (xfce)[build-system]: Use 'trivial-build-system'.
>> [arguments]: Simplify.
>
> Otherwise the patch LGTM.
Pushed, thanks!