[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add un-fonts (new patch, closes old thread)
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Add un-fonts (new patch, closes old thread) |
Date: |
Sun, 06 Mar 2016 14:49:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Nils Gillmann <address@hidden> skribis:
> I made the file being served from sdf.org available on
> krosos.sdf.org/static/unix/ and as soon as I get the okay from
> any other location (potentially in-berlin.de) I will change the
> location. Sdf.org is really permanent, but I prefer to move it to
> a place which could serve it via tls.
>
> From 2dcb24a8ea630311743bc8b661c57db0ffcb5be9 Mon Sep 17 00:00:00 2001
> From: Nils Gillmann <address@hidden>
> Date: Fri, 4 Mar 2016 23:04:16 +0100
> Subject: [PATCH] gnu: Add un-fonts.
>
> * gnu/packages/fonts.scm (font-un-fonts): New variable.
[...]
> + ;; origin server is serving us broken MIME
s/origin server/The upstream server at kldp.net/ plus period at the
end. :-) Also please add “See <http://bugs.gnu.org/22908>.” so we can
revisit this issue when the bug is fixed.
> + (name "font-un-fonts")
Shouldn’t it be “font-un-fonts-core” since that’s what the tarball is
called?
> + (version "1.0.2")
This should be “1.0.2-080608” IMO since this is what upstream calls it.
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://krosos.sdf.org/static/unix/"
> + "un-fonts-core-" version "-080608" ".tar.gz"))
Might be best to write:
(uri (list (string-append
"http://krosos.sdf.org" …)
;; XXX: The upstream server at kldp.net bla bla…
(string-append
"http://kldp.net/"…)))
That way, we keep the upstream URL around.
> + (home-page "https://kldp.net/projects/unfonts/")
> + (synopsis
> + "Un-fonts is a collection of Korean fonts")
Or “Collection of Korean fonts.”
> + (description
> + "Un-fonts is a family of mainly Korean fonts.
> +It contains the following fonts and styles:
> +
> +UnBatang, UnBatangBold: serif
> +UnDotum, UnDotumBold: sans-serif
> +UnGraphic, UnGraphicBold: sans-serif style
> +UnDinaru, UnDinaruBold, UnDinaruLight
> +UnPilgi, UnPilgiBold: script
> +UnGungseo: cursive, brush-stroke
Use @enumerate and @item for the list.
> + ;; GPL + embed exception for documents / images
> + (license license:gpl2+)))
‘README’ does not mention an “embedding exception” so I think the
comment is erroneous, or am I missing something?
Could you send an updated patch? We’re almost there! :-)
Thanks for persevering!
Ludo’.
Re: [PATCH] Add un-fonts (new patch, closes old thread), Nils Gillmann, 2016/03/06