Re: [PATCH] gnu: Add bioawk.

[Ricardo Wurmus]

Roel Janssen <address@hidden> writes:

> Please let me know when something is wrong with the patch.

In addition to Leo’s comments here are mine:

> +    (arguments
> +     `(#:parallel-build? #f

Why is parallel-build disabled?  Could you add a comment?

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (delete 'check)

We usually just do “#:tests? #f” with a comment, instead of deleting the
“check” phase.

> +         (replace
> +          'install

Please put “'install” on the same line as “(replace”.

> +          (lambda* (#:key outputs #:allow-other-keys)
> +            (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> +              (install-file "bioawk" bin)))))))
> +    (home-page "https://github.com/lh3/bioawk";)
> +    (synopsis "AWK with bioinformatics extensions")
> +    (description "Bioawk is an extension to Brian Kernighan's awk, adding the
> +support of several common biological data formats, including optionally 
> gzip'ed
> +BED, GFF, SAM, VCF, FASTA/Q and TAB-delimited formats with column names.  It
> +also adds a few built-in functions and an command line option to use TAB as 
> the

“a command-line option”, not “an”

Thanks!

~~ Ricardo