Re: [RFCv4] install: Create a GC root during install-grub.

[Ludovic Courtès]

Jookia <address@hidden> skribis:

> While previously creating a GC root for GRUB's resources was the caller's
> responsibility, it's much less repetitive to put it in install-grub now that
> it's wrapped by error handling. This also means we can replace the 
> install-grub*
> function with a small definition inside perform-action named 'install-boot'.
>
> * gnu/build/install.scm (install-grub): Make a GC root for grub.cfg on 
> success.
>   (register-grub.cfg-root): Remove function, install-grub does this now.
> * gnu/system/vm.scm (qemu-image): Don't explicitly make a GC root.
> * guix/scripts/system.scm (install-grub*): Move useful parts to 
> perform-action.
>   (perform-action): Use inline definition install-boot to install GRUB.

Is it different from v1 to v3?

I’m asking because I feel it might be difficult for me to find out what
the right version is when I start reviewing these.  :-)

Ludo’.