Re: [PATCHES] Upgrade Kodi to 16.0

[Ricardo Wurmus]

Thompson, David <address@hidden> writes:

> Hello Mathieu,
>
> On Sat, Mar 12, 2016 at 3:10 PM, Mathieu Lirzin <address@hidden> wrote:
>> Hello David,
>>
>> David Thompson <address@hidden> writes:
>>
>>>>From 80f08dde121610dcc832f4e6ecdd11341166580c Mon Sep 17 00:00:00 2001
>>> From: David Thompson <address@hidden>
>>> Date: Sat, 12 Mar 2016 12:23:47 -0500
>>> Subject: [PATCH 1/3] gnu: Add crossguid.
>>>
>>> * gnu/packages/kodi.scm (crossguid): New variable.
>>> ---
>> [...]
>>> +(define-public crossguid
>>> +  (let ((commit "8f399e8bd4252be9952f3dfa8199924cc8487ca4"))
>>> +    (package
>>> +      (name "crossguid")
>>> +      (version (string-append "0.0-1." (string-take commit 7)))
>>> +      ;; There's no official release.  Just a Git repository.
>>> +      (source (origin
>>> +                (method git-fetch)
>>> +                (uri (git-reference
>>> +                      (url "https://github.com/graeme-hill/crossguid.git";)
>>> +                      (commit commit)))
>>> +                (sha256
>>> +                 (base32
>>> +                  
>>> "1i29y207qqddvaxbn39pk2fbh3gx8zvdprfp35wasj9rw2wjk3s9"))))
>>
>> You have omitted “(file-name (string-append name "-" version ".tar.gz"))”.
>
> Not in this case because it's a git checkout, not a tarball download.

Shouldn’t it be named “...-checkout” then?  We do this a lot in the
bioinformatics.scm module.

~~ Ricardo