Re: [PATCH 12/13] gnu: Add python-rarfile.

[Leo Famulari]

On Fri, Mar 04, 2016 at 04:29:40PM -0500, Leo Famulari wrote:
> On Fri, Mar 04, 2016 at 01:42:11PM +0100, Ricardo Wurmus wrote:
> > 
> > Leo Famulari <address@hidden> writes:
> > 
> > > * gnu/packages/python.scm (python-rarfile, python2-rarfile): New
> > > variables.
> > > * gnu/packages/patches/python-rarfile-fix-tests.patch: New file.
> > > * gnu-system.am (dist_patch_DATA): Add it.
> > > ---
> > 
> > [...]
> > 
> > > +    (propagated-inputs
> > > +     `(("libarchive" ,libarchive)))
> > > +    (home-page "https://github.com/markokr/rarfile";)
> > > +    (synopsis "RAR archive reader for Python")
> > > +    (description "This is Python module for RAR archive reading. The 
> > > interface
> > > +is made as zipfile like as possible.")
> > > +    (license isc)))
> > 
> > Does this actually work?  I assumed that our “libarchive” package has no
> > support for RAR archives.
> 
> I don't know. The libarchive documentation in
> 'share/man/man5/libarchive-formats.5.gz' does list RAR as a supported
> format.

Also, libarchive's 'include/archive.h' defines ARCHIVE_FORMAT_RAR and
declares archive_read_support_format_rar().

I don't have any .rar archives to test with, and I haven't seen one in
years.

[...]

> So, what should I do? Patch "rarfile" out of setup.py or package
> python-rarfile?

Any feedback? I'd rather package python-rarfile.