[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: emacs-pdf-tools: Add missing input.
From: |
Alex Kost |
Subject: |
Re: [PATCH] gnu: emacs-pdf-tools: Add missing input. |
Date: |
Tue, 15 Mar 2016 23:15:25 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ludovic Courtès (2016-03-15 17:27 +0300) wrote:
> Alex Kost <address@hidden> skribis:
>
>> The bottom line of the following text is the question: Is it possible to
>> combine 2 (or more) build systems for building a package?
>
> Sure!
Great!
>> I did a little experiment: I thought maybe it could be possible just to
>> pick some build phases from (guix build emacs-build-system), so I added
>> this module to #:modules and #:imported-modules and added phases like
>> this:
>>
>> (modify-phases %standard-phases
>> ;; ...
>> (add-after 'build 'emacs-build
>> (@@ (guix build emacs-build-system) build))
>> (add-after 'install 'emacs-install
>> (@@ (guix build emacs-build-system) install)))
>>
>> The package was built successfully, but the result was not good, because
>> both gnu-build-system and emacs-build-system import %standard-phases :-)
>
> You mean “export”?
Yes, sometimes I mix up these words :-)
> I think you can always add a renamer upon import, using something like:
Ahahah, thanks!
> (package
> ;; …
> (arguments
> `(#:imported-modules ((guix build emacs-build-system)
> ,%gnu-build-system-modules)
> #:modules (((guix build emacs-build-system) #:prefix emacs:)
> ,%gnu-build-system-modules)
>
> #:phases (modify-phases %standard-phases ;from gnu-build-system
> (add-before 'build 'emacs-build
> (assoc-ref emacs:%standard-phases 'build))
> ;; …
> ))))
>
> Would it work for you?
Yes, brilliant! Now I know how to combine phases from different build
systems, thank you!
So I think it's better to use 2 commits here: one to update phases and
another to add let-alist dependency (both patches attached).
0001-gnu-emacs-pdf-tools-Use-emacs-build-system-for-elisp.patch
Description: Text Data
0002-gnu-emacs-pdf-tools-Add-missing-input.patch
Description: Text Data