guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/6] gnu: Add borg.


From: Leo Famulari
Subject: Re: [PATCH 5/6] gnu: Add borg.
Date: Mon, 21 Mar 2016 17:31:15 -0400
User-agent: Mutt/1.5.24 (2015-08-30)

On Tue, Mar 15, 2016 at 05:18:45AM -0400, Leo Famulari wrote:
> On Tue, Mar 15, 2016 at 12:11:15PM +0300, Alex Kost wrote:
> > Leo Famulari (2016-03-15 02:34 +0300) wrote:
> > > +       (modify-phases %standard-phases
> > > +         (add-before 'build 'set-openssl-prefix
> > > +           (lambda* (#:key inputs #:allow-other-keys)
> > > +             (setenv "BORG_OPENSSL_PREFIX" (assoc-ref inputs "openssl"))
> > > +             #t))
> > > +         (add-before 'build 'set-lz4-prefix
> > > +           (lambda* (#:key inputs #:allow-other-keys)
> > > +             (setenv "BORG_LZ4_PREFIX" (assoc-ref inputs "lz4"))
> > > +             #t))
> > 
> > Would it be better to make a single 'set-env' phase instead?  Or better
> > yet, are these '..._PREFIX' variables used for make command?  If so,
> > they should be specified in #:make-flags argument.
> 
> Thank you, that makes the recipe shorter and clearer.

I didn't test the change before replying ;)

There is no #:make-flags for the python-build-system, so I have used a
single set-env phase instead.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]