Re: [PATCH 2/2] Add jq

[Jelle Licht]

Thanks for your feedback Alex.

I have seen some other packages including multiple licenses in the list of licenses,

so I took that approach.

I also took the liberty of taking your description, which seems to also be coming directly from the jq website.

While digging into the valgrind issue, I found out that documentation is currently not being generated;

after looking at what was required for this to work, I worked things out up to the ruby-sass gem; I might finish
it if I have more time in the near future, but for now;

... jq, attempt two.

~Jelle

2016-03-26 20:13 GMT+01:00 Alex Griffin <address@hidden>:

Heh, I've had this packaged for ages (along with some others) and I've
put off submitting because I don't have a good workflow yet for
git+email. I should probably do something about that. Anyway, your
oniguruma package looks good to me. Here's a few notes about jq:

You listed jq's license at cc-by3.0, but that's only for the docs. Most
of the jq code is under the x11 license, except a few files which were
taken from other projects. I don't know how to specify multiple licenses
- maybe someone more experienced with Guix can chime in?

Your source URL is not stable (the hash will change at any time because
it's autogenerated by Github and not guaranteed to be identical). I
would use
https://github.com/stedolan/jq/releases/download/jq-1.5/jq-1.5.tar.gz
instead.

You should add valgrind as a dependency so that the test suite can run.

Finally, your description is a bit sparse. Here's what I wrote:

    jq is like sed for JSON data – you can use it to slice and filter
    and map and transform structured data with the same ease that sed,
    awk, grep and friends let you play with text.

    It is written in portable C, and it has zero runtime dependencies.

    jq can mangle the data format that you have into the one that you
    want with very little effort, and the program to do so is often
    shorter and simpler than you’d expect.

Hope that helps!
--
Alex Griffin


On Sat, Mar 26, 2016, at 12:41 PM, Jelle Licht wrote:
> ... and the actual package I wanted to use on guix!
> Email had 1 attachment:


>  * 0002-gnu-Add-jq.patch
>   3k (text/x-patch)

0002-gnu-Add-jq.patch
Description: Text Data