guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ffmpeg package update


From: Efraim Flashner
Subject: Re: ffmpeg package update
Date: Mon, 28 Mar 2016 09:34:09 +0300

On Thu, 24 Mar 2016 16:58:43 +0000
address@hidden wrote:

> Hello,
> 
> Our ffmpeg package is old (version 2.8.6 but 3.0 is available now).
> 
> I noticed this because I found a segfault in a program that uses mpv: 
> mkdir -p a ; mpv a. Updating ffmpeg fixes this.
> 
> Removed libquvi from it as that has been removed from mpv and is not 
> being updated.
> 
> Changed a configure flag --disable-mipsdspr1 to --disable-mipsdsp - this 
> is just a rename. You can read about this here 
> <https://ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183375.html> 
> since it's just a rename I do not think this will break ffmpeg on MIPS.

Like Leo said, patch looks good.

Don't forget to add yourself to the copyright line at the top :)

The commit message, it doesn't match up with the rest of the commit messages. 
There are many examples to copy from in the repo, and there's also the GNU 
manual here[0] which covers this also. Feel free to ask here or in irc if you 
need help with it, and can you send an updated patch?

Thanks!


[0] 
https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs

-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: pgpNCcxuulzFo.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]