Re: [PATCH] Add MilkyTracker to Guix

[Alex Kost]

Kei Yamashita (2016-03-30 05:24 +0300) wrote:

> Alright! This patch adds MilkyTracker successfully. It builds with
> both ALSA and JACK support. I took a look at the PKGBUILD from Arch
> Linux and the port dependencies from FreeBSD to make sure I had
> everything in order. Hopefully it is clean as far as syntax and guix
> standards go.

Great!  Thank you for fixing the build process!  I have only 4 small
comments:

1) Your previous patches contained:

+  #:use-module (gnu packages sdl)

But it is removed in this one.  I think it was done by mistake when you
removed the leftovers of other commits.

> If you could show me how you managed to get guix lint to
> run on this file, that would be great.

As Leo pointed, you can use "pre-inst-env" script to run guix tools from
a git checkout.  See (info "(guix) Running Guix Before It Is Installed")
for details.

> From e3a393da0ee6d0a22d4077a6f83601a8a246def3 Mon Sep 17 00:00:00 2001
> From: Kei Yamashita <address@hidden>
> Date: Tue, 29 Mar 2016 22:17:21 -0400
> Subject: [PATCH] gnu: Add MilkyTracker.
>
> * gnu/packages/music.scm (milkytracker): New variable.
> ---
>  gnu/packages/music.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index adda16a..9794c17 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -1306,3 +1306,33 @@ once and for all.  It catalogs your collection, 
> automatically improving its
>  metadata as it goes using the MusicBrainz database.  Then it provides a 
> variety
>  of tools for manipulating and accessing your music.")
>      (license license:expat)))
> +
> +(define-public milkytracker
> +  (package
> +    (name "milkytracker")
> +    (version "0.90.86")
> +    (source (origin
> +           (method url-fetch)
   ^^^^
2) tabulation on this line

> +              (uri (string-append "http://milkytracker.org/files/";
> +                                  name "-" version ".tar.bz2"))
> +              
   ^^^^^^^^^^^^^^
3) this redundant line

> +              (sha256
> +               (base32
> +                "1v9vp8vi24lkagfpr92c128whvakwgrm9pq2zf6ijpl5sh7014zb"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags '("CXXFLAGS=-lasound")))
> +    (inputs
> +     `(("alsa-lib" ,alsa-lib)
> +       ("jack" ,jack-1)
> +       ("sdl" ,sdl)
> +       ("zlib" ,zlib)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (synopsis "Music tracker for working with .MOD/.XM module files")
> +    (description "MilkyTracker is a music application for creating .MOD and 
> .XM
> +module files.  It attempts to recreate the module replay and user experience 
> of
> +the popular DOS program Fasttracker II, with special playback modes available
> +for improved Amiga ProTracker 2/3 compatibility.")
> +    (home-page "http://milkytracker.org/";)
> +    (license license:gpl3)))

4) I looked closer at the licenses.  It appeared to be that the code in
"src/milkyplay" is under Modified BSD (bsd-3), and the rest is under
GPL3 or later (gl3+).

The rest looks good to me, so I adjusted your patch for the mentioned
notes and committed it¹.  Oh, also I added a copyright line with your
name to the beginning of the file.  Thanks for contributing!

¹ 
http://git.savannah.gnu.org/cgit/guix.git/commit/?id=21d1811301c4acc34dc124c832d21918c2d11a95

-- 
Alex