Re: [PATCH] gnu: add vte-ng

[Alex Kost]

Mckinley Olsen (2016-03-30 02:52 +0300) wrote:

> Package vte-ng, which is needed by termite terminal (which I hope to
> package)

Hello, this is a great patch for the first package!  I have only a
couple of nitpicks and one real question.

> From c06b9fe54d33d6c8624426771fbb52606f751f58 Mon Sep 17 00:00:00 2001
> From: McKinley Olsen <address@hidden>
> Date: Mon, 28 Mar 2016 15:03:06 -0600
> Subject: [PATCH] gnu: add vte-ng.
Capital "Add" ----------^

> * gnu/packages/gnome.scm (vte-ng): added vte-ng package.

We write it like this:

  * gnu/packages/gnome.scm (vte-ng): New variable.

> ---
>  gnu/packages/gnome.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index eebb547..376ee74 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -1755,6 +1755,37 @@ gnome-terminal, but can also be used to embed a 
> console/terminal in games,
>  editors, IDEs, etc.")
>      (license license:lgpl2.1+)))
>  
> +(define-public vte-ng
> +  (package
> +    (inherit vte)
> +    (name "vte-ng")
> +    (version "0.42.4.a")
> +    (native-inputs
> +      `(("gtk-doc" ,gtk-doc)
> +        ("gperf" ,gperf)
> +        ("autoconf" ,autoconf)
> +        ("automake" ,automake)
> +        ("libtool" ,libtool)
> +        ,@(package-native-inputs vte)))
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url (string-append "https://github.com/thestinger/";
> +                                        name
> +                                        ".git"))
> +                    (commit version)))


Why do you use git instead of the latest tagged source?:

  https://github.com/thestinger/vte-ng/archive/0.44.0.a.tar.gz

> +              (file-name (string-append name "-" version))
> +              (sha256
> +               (base32
> +                "1w91lz30j5lrskp9ds5j3nn27m5mpdpn7nlcvf5y1w63mpmjg8k1"))))
> +    (arguments
> +      `(#:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'bootstrap
> +                    (lambda _
> +                      (setenv "NOCONFIGURE" "true")
> +                      (zero? (system* "sh" "autogen.sh")))))))))

I think it also would be good to add its own synopsis/description to
make it clear how it differs from "vte".

-- 
Alex