[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add xz-java.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH] gnu: Add xz-java. |
Date: |
Fri, 1 Apr 2016 14:45:01 +0200 |
Roel Janssen <address@hidden> writes:
> One minor detail is the filename of the jar. I renamed it to
> "xz-1.5.jar", which I think is the "standard" file naming scheme for our
> Java packages.
I think it’s a bit ugly because we have the version number in the target
directory already, but I realise that this is how the jar is originally
named, so I think that’s okay.
However, we should not hardcode the version string. Instead we should
do something like this (untested):
#:jar-name ,(string-append "xz-" version ".jar")
What do you think? If this works for you I’ll commit your patch with
this change.
~~ Ricardo