Re: [v2 2/2] gnu: Add signify.

[Leo Famulari]

On Sat, Apr 02, 2016 at 10:47:21AM +0300, Alex Kost wrote:
> Leo Famulari (2016-04-02 04:24 +0300) wrote:
> 
> > * gnu/packages/crypto.scm (signify): New variable.
> > ---
> >  gnu/packages/crypto.scm | 35 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> [...]
> > +(define-public signify
> > +  (package
> > +    (name "signify")
> > +    (version "17")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append "https://github.com/aperezdc/signify/";
> > +                                  "archive/v" version ".tar.gz"))
> 
> Don't forget about "guix lint": you are missing (file-name ...) field here.
> 
> > +              (sha256
> > +               (base32
> > +                "0kfv2k1fqck31vwlnicavb0h541ilad9zd7j8zz8x2kx36wwqpr7"))))
> > +    (build-system gnu-build-system)
> > +    ;; TODO Build with libwaive (described in README.md), to implement 
> > something
> > +    ;; like OpenBSD's pledge().
> > +    (arguments
> > +     `(#:make-flags
> > +       (list "CC=gcc"
> > +             (string-append "PREFIX=" (assoc-ref %outputs "out")))
> > +       #:phases
> > +       (modify-phases %standard-phases
> > +         (delete 'configure)
> > +         (delete 'check)))) ; no test suite
> 
> I think it's better to add “#:tests? #f” to arguments instead, as we do
> for other packages.
> 
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)))
> > +    (inputs
> > +     `(("libbsd" ,libbsd)))
> > +    (synopsis "Create and verify cryptographic signatures")
> > +    (description "The signify utility creates and verifies cryptographic
> > +signatures using the elliptic curve Ed25519.")
> > +    (home-page "https://github.com/aperezdc/signify";)
> > +    (license (list bsd-3 bsd-4 isc public-domain non-copyleft))))
> 
> The same note as for 'libbsd': non-copyleft is a procedure.

Thanks for the review! I've made all the requested changes.