Re: [PATCH] gnu: Add wmbattery

[Leo Famulari]

On Mon, Apr 04, 2016 at 05:04:51PM -0400, Kei Yamashita wrote:

Thanks for the patch!

As suggested by Danny, please run `guix lint` on it.

+    (version "2.50")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append
+                   "http://http.debian.net/debian/pool/main/w/wmbattery/\
+wmbattery_2.50.orig.tar.gz"))

Can you re-use the version variable in the uri? There are many examples
of how to do this in the 'gnu/packages' directory of the Guix source
code.

Also, can you add a comment explaining why we fetch the source from
Debian?

+                  (delete 'check))))

Can you instead use the form '#:tests? #f', and add a comment explaining
why the tests are disabled? There are also examples of this in
'gnu/packages'.

Can you send an updated patch?