[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] emacs: Use 'build-and-use-profile' from (guix scripts packag
From: |
Alex Kost |
Subject: |
Re: [PATCH] emacs: Use 'build-and-use-profile' from (guix scripts package). |
Date: |
Wed, 06 Apr 2016 01:04:29 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ludovic Courtès (2016-04-05 12:59 +0300) wrote:
> Alex Kost <address@hidden> skribis:
>
>> This is to remove code duplication in "emacs/guix-main.scm" and
>> "guix/scripts/package.scm" ('build-and-use-profile' did not exist until
>> commits 1b67644 and d1ac5c0).
>>
>> The only important (or maybe not) difference is:
>>
>> (set-guile-for-build (default-guile))
>>
>> in "guix-main.scm" which does not exist in 'build-and-use-profile'. It
>> was introduced in commit 4ad2e76 and I don't really understand why it is
>> needed.
>
> For future reference, this was(?) needed because ‘run-with-store’ has
> its #:guile parameter default to (%guile-for-build), which itself
> defaults to #f (4ad2e76 and e87f059 hint at this.)
>
> I presume that somehow ‘%guile-for-build’ or #:guile gets the right
> value in this case.
Thanks for the info! I already pushed this patch, and I have not had
any problems with it so far. Let's see if it will introduced bugs or
not :-)
--
Alex