Re: [PATCH 5/6] emacs: Add interface for package locations.

[Alex Kost]

Ludovic Courtès (2016-04-05 23:50 +0300) wrote:

> Alex Kost <address@hidden> skribis:
>
>> * emacs/guix-main.scm (%package-location-param-alist): New variable.
>> (package-location->sexp, package-location-entries): New procedures.
>> * emacs/guix-ui-location.el: New file.
>> * emacs.am (ELFILES): Add it.
>> * doc/emacs.texi (Emacs Locations): Document 'guix-locations'.
>> * NEWS: Mention it.
>> ---
>>  NEWS                      |  6 ++++
>>  doc/emacs.texi            |  7 ++++
>>  emacs.am                  |  1 +
>>  emacs/guix-main.scm       | 12 +++++++
>>  emacs/guix-ui-location.el | 83 
>> +++++++++++++++++++++++++++++++++++++++++++++++
>>  5 files changed, 109 insertions(+)
>>  create mode 100644 emacs/guix-ui-location.el
>
> That it takes so few lines to implement this is a good sign.  :-)

I also think so ;-)

>> +*** New Emacs interface for package locations: M-x guix-locations
>
> s/for package locations/to navigate package definitions/ ?

This is not really for "package definitions" ("M-x guix-edit" is to move
to a particular definition), but for package location files.

Also it is not just "to navigate".  Opennig a location file is a smaller
feature.  *Guix Package Locations* buffer can also be used to display
packages from a particular location (similar to displaying packages from
a particular generation that you can do from *Guix Generation List*
buffer).

Finally, *Guix Package Locations* buffer is useful by itself!  When you
want to look at how many packages are placed in this or that location.

So I would still prefer a more general «interface for package locations».

>> address@hidden M-x guix-locations
>> +Display a list of package locations.  You can press @key{RET} there to
>
> Maybe “Display the list of source files that define packages.”?

I prefer the term "package location" over "source file that define
packages".  It looks simple and understandable to me, but if you insist,
I will change it.

-- 
Alex