Re: [PATCH v2] gnu: Add python2-shedskin.

[Leo Famulari]

On Wed, Mar 30, 2016 at 07:26:59AM +0200, Danny Milosavljevic wrote:
> Patch that does the latter. Is that OK?

If it works, then I think it's better than propagating pcre and libgc.

> * gnu/packages/python.scm (python2-shedskin): New variable.

> +      (uri (string-append 
> "https://github.com/shedskin/shedskin/releases/download/v"; version 
> "/shedskin-0.9.4.tgz"))

Please use 'version' in place of 0.9.4 in the URL.

> +  (arguments `(#:python ,python-2

The home page says that it works with python 2.4 – 2.6. Is that a
problem? We don't package any versions within that range.

> +               #:phases (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-resulting-include-libs
> +          (lambda* (#:key inputs #:allow-other-keys)
> +            (let ((libgc (assoc-ref inputs "libgc"))
> +                  (pcre (assoc-ref inputs "pcre")))
> +              (substitute* "shedskin/makefile.py"
> +                (("variable == 'CCFLAGS':")
> +                 (string-append "variable == 'CCFLAGS':\n            line += 
> ' -I " pcre "/include -I " libgc "/include'"))
> +                (("variable == 'LFLAGS':")
> +                 (string-append "variable == 'LFLAGS':\n            line += 
> ' -L" pcre "/lib -L " libgc "/lib'")))
> +              #t))))))

Overall, the indentation of 'arguments' is inconsistent. Can you try to
clean it up? If not, I can do it when committing your revised patch.

> +  (native-inputs `(("python2-setuptools" ,python2-setuptools)))
> +  (inputs `(("pcre" ,pcre)
> +            ("libgc" ,libgc)))
> +  (home-page "https://shedskin.github.io/";)
> +  (synopsis "Python Native Compiler")

The word 'native' doesn't appear on the home-page or in any relevant
part of the code base. How about "Experimental Python-2 to C++
compiler". You know more about this program than me, but that seems
reasonable based on the software's documentation and web site.

> +  (description "This is a native compiler for a subset of Python.  It 
> generates C++ code and a Makefile.")

As with the synopsis...

> +  (license (list gpl3 bsd-3 expat))))

Is the 'examples' directory included in the package when installed?
If so, those files have some more licenses that should be listed.

Can you send a revised patch, making sure to satisfy `./pre-inst-env guix
lint shedskin` before sending?