Re: [PATCH 2/2] gnu: Add gnome-tweak-tool.

[Leo Famulari]

On Sun, Apr 03, 2016 at 01:07:34PM +0200, Jan Nieuwenhuizen wrote:
> Hi,
> 
> Finally gnome-tweak-tool works!  That should make the Gnome desktop a
> workable alternative [workspace grid] until we get a nicely hackable
> guile-wm up and running.
> 
> It needs libnotify to be compiled with gobject-introspection,
> attached as [PATCH 1/2].

I still don't understand how all the parts of GNOME fit together, so I
can't give a full review of these patches.

But, with these patches, I can successfully prevent my laptop from
sleeping when the lid is closed. Thank you!

> * gnu/packages/gnome.scm (libnotify)[native-inputs]: Add
>   gobject-introspection.

Looks okay, but as I said before, I'm no expert on this stuff.

> * gnu/packages/patches/gnome-tweak-tool-search-paths.patch: New file.

Can you add some comments explaining this patch (and a link to the source, if
applicable)?

> * gnu-system.am: Add it.

Please specify which section of gnu-system.am the file is being added
to. In this case, it's dist_patch_DATA. See the commit log for the exact
format.

> * gnu/packages/gnome.scm (gnome-tweak-tool): New variable.
> +         (replace 'install
> +           (lambda _
> +             (zero? (system* "make"
> +                             "sysconfdir=/tmp"
> +                             "localstatedir=/tmp"
> +                             "install")))))))

How about setting these variables in #:make-flags instead of replacing
the install phase? Would that work?

> +    (propagated-inputs
> +     `(("gobject-introspection" ,gobject-introspection)
> +       ("gnome-shell" ,gnome-shell)
> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> +       ("gtk+" ,gtk+)
> +       ("libnotify" ,libnotify)
> +       ("mutter" ,mutter)
> +       ("python2" ,python-2)
> +       ("python2-pygobject" ,python2-pygobject)))

Oof, do we really have to propagate python-2 (and the others)?

> +    (synopsis "Gnome Tweak Tool")

Can you paraphrase this? I don't think the synopsis should be the same
as the package name. How about something like this: "GNOME advanced
settings control panel"?