[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: geda-gaf: Make gsch2pcb work out-of-the-box.
|
From: |
Thompson, David |
|
Subject: |
Re: [PATCH] gnu: geda-gaf: Make gsch2pcb work out-of-the-box. |
|
Date: |
Wed, 13 Apr 2016 12:07:41 -0400 |
On Wed, Apr 13, 2016 at 12:05 PM, Eric Bavier
<address@hidden> wrote:
> On 2016-04-13 09:45, Thompson, David wrote:
>>
>> * gnu/packages/engineering.scm (geda-gaf)[inputs]: Add m4 and pcb.
>> [arguments]: Add configure flags that point to PCB data files.
>
>
> Nitpick: '[' should align with "gnu".
The GNU ChangeLog standards say not to do this. We used to indent for
awhile, but have since stopped.
> Is m4 really required at runtime?
Yes, it is. Transforming a schematic to a PCB, for example, requires
processing M4 macros.
Thanks for the review! I'm going to push this.
- Dave