guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/9] gnu: Add brotli.


From: Ludovic Courtès
Subject: Re: [PATCH 4/9] gnu: Add brotli.
Date: Wed, 13 Apr 2016 23:44:58 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

address@hidden skribis:

> From: Eric Bavier <address@hidden>
>
> * gnu/packages/compression.scm (brotli): New variable.

[...]

> +  (let ((commit "e992cce7a174d6e2b3486616499d26bb0bad6448"))
> +    (package
> +      (name "brotli")
> +      (version "0.1")

Please use a version string as noted in the guidelines (info "(guix)
Version Numbers").


[...]

> +       `(#:phases (modify-phases %standard-phases
> +                    (add-after 'unpack 'autogen
> +                      (lambda _
> +                        (mkdir "m4")
> +                        (system* "autoreconf" "-vfi"))))))

(zero? (system* …))

> +      (synopsis "Brotli encoder/decoder libraries")

Maybe “Implementation of the Brotli compression algorithm” or something
like this to hint at the application domain?

> +      (description
> +       "This package provides Brotli encoder and decoder libraries: 
> libbrotlienc
> +and libbrotlidec, respectively.")

Could you expound the description a little bit?  :-)

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]