Re: [PATCH 1/5] gnu: Add avr-binutils.

[Ludovic Courtès]

David Thompson <address@hidden> skribis:

> * gnu/packages/avr.scm (avr-binutils): New variable.

[...]

> +(define-public avr-binutils
> +  (package
> +    (inherit (cross-binutils "avr"))
> +    (name "avr-binutils")
> +    (arguments
> +     '(#:configure-flags '("--target=avr"
> +                           "--disable-nls")))))

AFAICS --target=avr is redundant:

--8<---------------cut here---------------start------------->8---
$ git describe
v0.10.0-204-ga2d0e20
$ wget -q -O - $(./pre-inst-env guix build --log-file -e '((@ (gnu packages 
cross-base) cross-binutils) "avr")') |grep -e --target
configure flags: 
("CONFIG_SHELL=/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42/bin/bash"
 "SHELL=/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42/bin/bash" 
"--prefix=/gnu/store/gqmq8gis9igpg4xy6022mvq8qpvp7kk4-binutils-cross-avr-2.25.1"
 "--enable-fast-install" "--build=x86_64-unknown-linux-gnu" "--target=avr" 
"--with-sysroot=/" "LDFLAGS=-static-libgcc" "--with-lib-path=/no-ld-lib-path" 
"--disable-werror" "--enable-install-libbfd" "--enable-deterministic-archives")
--8<---------------cut here---------------end--------------->8---

… and --disable-nls is orthogonal and probably unnecessary.

Can we skip this patch?  :-)

Ludo’.