Re: [PATCH] Add cabextract.

[Ricardo Wurmus]

Danny Milosavljevic <address@hidden> writes:

> Hi,
>
> this patch adds cabextract, an extractor for CAB files. (libmspack is already 
> in, but cabextract isn't)
>
>   * gnu/packages/compression.scm (cabextract): New variable.
> ---
>  b/gnu/packages/compression.scm |   23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
> index 938d4b8..9343e85 100644
> --- a/gnu/packages/compression.scm
> +++ b/gnu/packages/compression.scm
> @@ -688,3 +688,26 @@ a collection of smaller blocks which makes random access 
> to the original data
>  possible and can compress in parallel.  This is especially useful for large
>  tarballs.")
>      (license license:bsd-2)))
> +
> +(define-public cabextract
> + (package
> +   (name "cabextract")
> +   (version "1.6")
> +   (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://cabextract.org.uk/cabextract-"; version 
> ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1ysmmz25fjghq7mxb2anyyvr1ljxqxzi4piwjhk0sdamcnsn3rnf"))))
> +    (build-system gnu-build-system)
> +    (arguments '(#:configure-flags '("--with-external-libmspack")))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ))

Please move these two closing parentheses to the previous line.

> +    (inputs
> +     `(("libmspack" ,libmspack)))
> +    (home-page "http://www.cabextract.org.uk/";)
> +    (synopsis "CAB Extractor")
> +    (description "cabextract extracts files from CAB archives.")

Both synopsis and description are very terse.  For the synopsis
something like “Tool to unpack CAB archives” might be a little less
cryptic.  I don’t have any alternative for the description, but it would
be nice if it were a little less terse.

> +    (license (list license:gpl2 license:gpl3))))

Could you add a comment explaining what this means?  Are parts of the
code released under GPLv2 only?

~~ Ricardo