Re: [PATCH] Add vcflib.

[Ricardo Wurmus]

Roel Janssen <address@hidden> writes:

> From ec8d80b1be2d4271b6a1583a1c1a6264d37ccbeb Mon Sep 17 00:00:00 2001
> From: Roel Janssen <address@hidden>
> Date: Tue, 22 Mar 2016 15:10:53 +0100
> Subject: [PATCH 4/8] gnu: Add fsom.

> * gnu/packages/bioinformatics.scm (fsom): New variable.
> ---
>  gnu/packages/bioinformatics.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)

> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index 9465d56..0abccbc 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -4896,3 +4896,30 @@ combination generation algorithm which is 
> (approximately) described in
>  combinatorial configurations.\" G Ehrlich - Journal of the ACM (JACM),
>  1973. (Algorithm 7.)")
>      (license license:expat)))
> +
> +(define-public fsom
> +  (let ((commit "a6ef318fbd347c53189384aef7f670c0e6ce89a3"))
> +    (package
> +      (name "fsom")
> +      (version (string-append "0-1." (string-take commit 7)))
> +      (source (origin
> +        (method url-fetch)
> +        (uri (string-append "https://github.com/ekg/fsom/archive/";
> +                            commit ".tar.gz"))
> +        (file-name (string-append name "-" version "-checkout.tar.gz"))
> +        (sha256
> +         (base32 "0q6b57ppxfvsm5cqmmbfmjpn5qvx2zi5pamvp3yh8gpmmz8cfbl3"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:tests? #f ; There are no tests to run.
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure) ; There is no configure phase.
> +           (replace 'install
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> +                 (install-file "fsom" bin)))))))
> +      (home-page "https://github.com/ekg/fsom";)
> +      (synopsis "Program for managing SOM (Self-Organizing Maps)
> neural networks")

This is a bit long.  I’d drop the abbreviation and its expansion.  Is
this a program or a library?

> +      (description "Program for managing SOM (Self-Organizing Maps)
> neural networks.")

Could you please turn this into a full sentence?

> +      (license license:gpl3))))

Looks right.  “fsom.c” says “License: GNU GPL v.3”.

~~ Ricardo