Re: [PATCH] Add junit.

[Eric Bavier]

On 2016-04-22 09:16, Ricardo Wurmus wrote:
> Hi Guix,
>
> here’s a first batch of patches for Java libraries.  Many Java packages
> depend on JUnit, so that’s where I started.  “hamcrest-core” is just a
> small part of the whole hamcrest library, but it’s enough to build
> JUnit.
[...]
> +         (add-before 'configure 'patch-build.xml
> +           (lambda _
> +             (substitute* "build.xml"
> +               (("unit-test, ") "")
> +               (("\\$\\{build.timestamp\\}") "guix"))

Is using "guix" here as a timestamp safe?  Will nothing read the 
manifest and expect an actualy timestamp?  (I've become unfamiliar with 
most of java-land lately).

> +         ;; Java's "getMethods()" returns methods in an unpredictable 
> order.
> +         ;; To make the output of the generated code deterministic we 
> must
> +         ;; sort the array of methods.
> +         (add-after 'unpack 'make-method-order-deterministic

Should we patch our java package instead?  Perhaps that can be saved as 
a future exercise.

> +              (snippet
> +               '(begin
> +                  ;; Delete bundled jar archives.
> +                  (delete-file-recursively "lib")
> +                  #t))))

Is this very common in java packages?

Otherwise LGTM.

--
`~Eric