[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] gnu: Add python-tblib and python2-tblib
From: |
Leo Famulari |
Subject: |
Re: [PATCH 1/6] gnu: Add python-tblib and python2-tblib |
Date: |
Sun, 24 Apr 2016 15:40:43 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Apr 21, 2016 at 09:19:48PM +0200, Hartmut Goebel wrote:
> * packages/python.scm (python-tblib) (python2-tblib): New
> variables.
Thanks for the updated patch!
> +(define-public python-tblib
> + (package
> + (name "python-tblib")
> + (version "1.3.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "tblib" version))
> + (sha256
> + (base32
> + "02iahfkfa927hb4jq2bak36ldihwapzacfiq5lyxg8llwn98a1yi"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (replace 'check
> + ;; Run py.test, excluding some file which are no tests and fail to i
> + ;; mport. Excluding know problem-files is less intrusive to what
> + ;; upstream has configured to be tested than restricting to only
> scan
> + ;; directory tests/.
> + (lambda _
> + (zero? (system* "py.test" "--ignore=setup.py"
> + "--ignore=docs/conf.py"
> + "--ignore=ci/appveyor-download.py")))))))
I wonder if this really the best thing to do? With this method, the only
files that appear to be "tested" are the various .rst files, which are
just documentation.
Can you ask upstream how they prefer the tests to be run?
- [PATCH 0/6] Updated: Some new python packages, Hartmut Goebel, 2016/04/21
- [PATCH 4/6] gnu: Add python2-ipaddr, a Python-2-only package, Hartmut Goebel, 2016/04/21
- [PATCH 1/6] gnu: Add python-tblib and python2-tblib, Hartmut Goebel, 2016/04/21
- Re: [PATCH 1/6] gnu: Add python-tblib and python2-tblib,
Leo Famulari <=
- [PATCH 6/7] gnu: add comment pointing to python-requests-mock in openstack, Hartmut Goebel, 2016/04/21
- [PATCH 5/6] gnu: add python-maxminddb and python2-maxminddb, Hartmut Goebel, 2016/04/21
- [PATCH 6/6] gnu: add python-geoip2 and python2-geoip2, Hartmut Goebel, 2016/04/21
- [PATCH 7/7] gnu: add python-geoip2 and python2-geoip2, Hartmut Goebel, 2016/04/21