guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8.


From: Ben Woodcroft
Subject: Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8.
Date: Mon, 25 Apr 2016 09:42:05 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0



On 25/04/16 03:04, Efraim Flashner wrote:
On Sun, Apr 24, 2016 at 11:06:17PM +1000, Ben Woodcroft wrote:
[..]
+             (let ((out (assoc-ref outputs "out")))
+               (setenv "PYTHONPATH"
+                       (string-append
+                        (getenv "PYTHONPATH")
+                        ":"
+                        out
+                        "/lib/python"
some of the previous lines should be combined into one line

I think this is a matter of style, but I've amended it to below, which I assume is OK - I have no strong opinions.

+               (setenv
+                "PYTHONPATH"
+                (string-append (getenv "PYTHONPATH")":" out "/lib/python"
+                               (string-take (string-take-right
+                                      (assoc-ref inputs "python") 5) 3)
+                               "/site-packages"))


+                        (string-take (string-take-right
+                                      (assoc-ref inputs "python") 5) 3)
+                        "/site-packages"))
+               (zero?
+                (system*
+                 (string-append out "/bin/py.test") "test_pep8.py"))))))))
+    (propagated-inputs
+     `(("python-pytest-cache", python-pytest-cache)
+       ("python-pytest" ,python-pytest)
+       ("python-pep8" ,python-pep8)))
Are you sure all of these need to be propagated?

That's what the install_requires in setup.py is telling me.

Thanks,
ben



reply via email to

[Prev in Thread] Current Thread [Next in Thread]