Re: [PATCH v4 1/9] gnu: cross: Use CROSS_*_INCLUDE_PATH for system headers.

[Jan Nieuwenhuizen]

Jan Nieuwenhuizen writes:

Just a quick thing I noticed while preparing new patch

>>> +-  if (temp && *cross_compile == '0')
>>> ++  if (temp)
>>> +     {
>>> +       const char *startp, *endp;
>>> +       char *nstore = (char *) alloca (strlen (temp) + 3);
>>
>> Why this change?
>
> Not a change per se, AIUI our cross patch makes COMPILER_PATH now
> valid, as we populate it from CROSS_*.

This is foo; this change is only for LIBRARY_PATH_ENV and the patch
above reverts the one below, making them a no-op

>>> --  if (temp && *cross_compile == '0')
>>> -+  if (temp)
>>> -     {
>>> -       const char *startp, *endp;
>>> -       char *nstore = (char *) alloca (strlen (temp) + 3);
>>> -- 
>>> 2.7.3
>>
>> Similar comment as above.
>
> Not a change per se, AIUI our cross patch makes LIBRARY_PATH[_ENV] now
> valid, as we populate it from CROSS_LIBRARY_PATH.

In my new patch this gcc.c patch was the first, and the old guix patch
it was the last.  I have moved this gcc.c patch it to the bottom now and
then it dissappears from the guix patch. :-)

Greetings, Jan

-- 
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl