guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] New pinentries


From: Leo Famulari
Subject: Re: [PATCH 0/2] New pinentries
Date: Tue, 26 Apr 2016 13:13:09 -0400
User-agent: Mutt/1.5.24 (2015-08-30)

On Tue, Apr 26, 2016 at 04:33:16PM +0200, Ricardo Wurmus wrote:
> 
> Hi Efraim,
> 
> > On a whim I removed gtk2 and glib from pinentry and the size of the closure
> > dropped from 700 MiB to 100 MiB. While I was at it I built a version with
> > qt5, if someone wanted it to match a future kde/qt-based desktop. I couldn't
> > get a gtk3 version building, but I didn't try too hard.
> >
> > Efraim Flashner (2):
> >   gnu: Add minimal pinentry.
> >   gnu: Add pinentry-qt.
> >
> >  gnu/packages/gnupg.scm | 34 +++++++++++++++++++++++++++++-----
> >  1 file changed, 29 insertions(+), 5 deletions(-)
> 
> These both look good to me.  I think our policy requires to split the
> first patch in two, one to reduce pinentry, the other to add
> pinentry-gtk2, but I’m not sure.

I had the same thought, but it would mean we have a commit in our
history where we *don't* have the GTK pinentry. I think we should avoid
that.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]