Re: [PATCH] gnu: Add xz-java.

[Roel Janssen]

0001-gnu-Add-java-xz.patch
Description: Text Data

Ricardo Wurmus writes:

> Hi Roel,
>
>> Ricardo Wurmus writes:
>>
>>> Roel Janssen <address@hidden> writes:
>>>
>>>> One minor detail is the filename of the jar.  I renamed it to
>>>> "xz-1.5.jar", which I think is the "standard" file naming scheme for our
>>>> Java packages.
>>>
>>> I think it’s a bit ugly because we have the version number in the target
>>> directory already, but I realise that this is how the jar is originally
>>> named, so I think that’s okay.
>>
>> The jar is originally named "xz.jar".  I thought other Java packages
>> included the version number in the filename, so I just followed this
>> practice.
>>
>> Either "xz.jar" or "xz-1.5.jar" is fine with me.
>>
>>> However, we should not hardcode the version string.  Instead we should
>>> do something like this (untested):
>>>
>>>     #:jar-name ,(string-append "xz-" version ".jar")
>>>
>>> What do you think?  If this works for you I’ll commit your patch with
>>> this change.
>>
>> I've just tested it and it works.  Since you're better at making a
>> stylistic decision, I want to leave it up to you whether you want to
>> append the version number or not.  Both ways are fine with me.
>
> I forgot to reply to this message and I no longer remember what we
> should do.  Do you have an updated patch for “java-xz” (with or without
> version number)?

Yes, here it is.  So, I renamed it to "java-xz" due to the naming
conventions.  I applied your suggestion of making the version a variable
in the #:jar-name field.

Thanks!

Kind regards,
Roel Janssen