Re: [PATCH] gnu: Add 4store.

[Roel Janssen]

0001-gnu-Add-4store.patch
Description: Text Data

Leo Famulari writes:

> On Tue, Mar 29, 2016 at 08:54:40AM +0200, Roel Janssen wrote:
>> Leo Famulari writes:
>> > Why use this commit instead of the last release?
>> 
>> I like especially these subtle changes/fixes:
>> - run-time configurable HTTP log directory:
>>   commit 1725502cf01130ee80cf9b72249bbfc0f61f17fb
>> - Fix for potential pointer arithmetic error:
>>   commit 6e2b4a70d4934484706a67b688ac30f3ca7baf98
>
> It's true, those are nice changes to have. But then again, most of our
> packages have some nice changes between the latest release and HEAD.
>
> The best solution would be for 4store to issue a new release, especially
> if that pointer arithmetic issue is a real problem. Can you ask them if
> they are planning a new release soon?

Right.  I think it's too soon for a new release, as there are many
outstanding bugs to be fixed.  I reverted the version of my patch to the
latest official release.

I also changed the home-page link because 4store.org is still down and
it doesn't look like that is going to change any time soon.

I attached a new patch that should be fine.  When I applied the patch
myself I got two warnings about trailing whitespace.  I tried a modified
patch without spaces after the make target names, but it failed to apply
the patch when building 4store.  Therefore, I left the whitespace as is,
and I think we should leave the warnings be.

Thanks for your time and effort!

Kind regards,
Roel Janssen