Re: Gnome-updates

[Ludovic Courtès]

Hello!

Regarding the gjs failure worked around by commit
63e7796f626ee40b8259ce56b93f5596e8a1f8c5, I briefly investigated.  Upon
failure, the ‘stderr.log’ file reads:

--8<---------------cut here---------------start------------->8---
Gjs-Message: JS LOG: Expected nonconst ♥ utf8 (string) but was  (string)

Stack trace follows:
address@hidden:///org/gnome/gjs/modules/jsUnit.js:272
address@hidden:///org/gnome/gjs/modules/jsUnit.js:110
address@hidden:///org/gnome/gjs/modules/jsUnit.js:147
testUtf8@/tmp/guix-build-gjs-1.44.0.drv-0/gjs-1.44.0/installed-tests/js/testEverythingBasic.js:162
address@hidden:///org/gnome/gjs/modules/jsUnit.js:438
@/tmp/guix-build-gjs-1.44.0.drv-0/gjs-1.44.0/installed-tests/js/testEverythingBasic.js:699
--8<---------------cut here---------------end--------------->8---

This corresponds to this test in ‘testEverythingBasic.js’:

--8<---------------cut here---------------start------------->8---
   function testUtf8() {
       const CONST_STR = "const \u2665 utf8";
       const NONCONST_STR = "nonconst \u2665 utf8";

       JSUnit.assertEquals(CONST_STR, Everything.test_utf8_const_return());
       JSUnit.assertEquals(NONCONST_STR, 
Everything.test_utf8_nonconst_return());
       Everything.test_utf8_const_in(CONST_STR);
       JSUnit.assertEquals(NONCONST_STR, Everything.test_utf8_out());
*      JSUnit.assertEquals(NONCONST_STR, Everything.test_utf8_inout(CONST_STR));
       JSUnit.assertEquals(NONCONST_STR, Everything.test_utf8_inout(CONST_STR));
       JSUnit.assertEquals(NONCONST_STR, Everything.test_utf8_inout(CONST_STR));
       JSUnit.assertEquals(NONCONST_STR, Everything.test_utf8_inout(CONST_STR));
   }
--8<---------------cut here---------------end--------------->8---

The ‘test_utf8_inout’ function is bound via ‘Regress-1.0.git’, and its
definition is in $(guix build
gobject-introspection)/share/gobject-introspection-1.0/tests/regress.c:

--8<---------------cut here---------------start------------->8---
void
regress_test_utf8_inout (char **inout)
{
  /* inout parameter, transfer mode full */
  g_assert (strcmp (*inout, utf8_const) == 0);
  g_free (*inout);
  *inout = g_strdup (utf8_nonconst);
}
--8<---------------cut here---------------end--------------->8---

… where:

--8<---------------cut here---------------start------------->8---
static const char utf8_nonconst[] = "nonconst \xe2\x99\xa5 utf8";
--8<---------------cut here---------------end--------------->8---

So it seems that it’s a failure of ‘g_strdup’, or in
‘gjs_string_from_utf8’ in jsapi-util-string.cpp.

I’ll pass it on to you or anyone else.  :-)

Ludo’.