Re: [PATCH 4/6] gnu: gnome-documents

[Leo Famulari]

On Wed, Apr 20, 2016 at 08:26:47AM -0500, address@hidden wrote:
> On 2016-04-18 13:44, Leo Famulari wrote:
> >On Thu, Apr 14, 2016 at 10:35:00AM -0500, address@hidden wrote:
> >>On 2016-03-29 14:25, address@hidden wrote:
> >>>address@hidden skribis:
> >>>
> >>>>+     `(#:configure-flags
> >>>>+       '("--with-ca-certificates=/etc/ssl/certs/ca-certificates.crt")
> >>>
> >>>AFAICS glib-networking uses GnuTLS, for which we already had such a
> >>>setting (except that it can read all the .crt files from /etc/ssl/certs,
> >>>not just one bundle.)
> >>
> >>I did more tests and remove this part.
> >>
> >>>>+       (modify-phases %standard-phases
> >>>>+         (add-before 'check 'use-empty-ssl-cert-file
> >>>>+                     (lambda _
> >>>>+                       ; Search for ca-certificates.crt files
> >>>>+                       ; during the check phase.
> >>>>+                       (setenv "SSL_CERT_FILE" "/dev/null")
> >>>
> >>>Does this really have an effect?  This is the environment variable used
> >>>by OpenSSL, but not GnuTLS.
> >>
> >>indeed, it works.
> >>
> >>Question, to which package module I can add the patch?
> >
> >I've moved it into web.scm, in the attached revision on your patch. I
> >can apply it if you think it looks good. What do you think?
> >
> >I also reorganized the native-inputs a little bit, to put all the
> >"check" dependencies together.
> >
> >By the way, thanks for working on this patch series, and SORRY for the
> >slow review!
> 
> Hi, I think it's okay.

Applied as 7ffbbea00d0!

> 
> Thanks