guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/10] gnu: Add libiconv.


From: Manolis Ragkousis
Subject: Re: [PATCH 06/10] gnu: Add libiconv.
Date: Sun, 1 May 2016 20:07:56 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

Καλησπέρα Jan,

On 04/29/2016 06:12 PM, Jan Nieuwenhuizen wrote:
> +  #:use-module (guix build-system trivial)
> +  #:export (glibc
> +            libiconv-if-needed))

The #:export (glibc...) part only exists in wip-hurd so we need to
remove this in order for your patch to apply on master.

> +(define-public libiconv
> +  (package
> +   (name "libiconv")
> +   (version "1.14")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append
> +                  "mirror://gnu/libiconv/libiconv-"
> +                  version ".tar.gz"))
> +            (sha256
> +             (base32
> +              "04q6lgl3kglmmhw59igq1n7v3rp1rpkypl366cy1k1yn2znlvckj"))))
> +   (build-system gnu-build-system)
> +   (synopsis "Character set conversion library")
> +   (description
> +     "libiconv provides an implementation of the iconv function for systems
> +that lack it.  iconv is used to convert between character encodings in a
> +program.  It supports a wide variety of different encodings.")
> +   (home-page "http://www.gnu.org/software/libiconv/";)
> +   (license lgpl3+)))

Maybe we should break this patch into two different ones, one for the
libiconv package description and one for the libiconv-if-needed. The
first will go to master and the second to core-updates. WDYT?

> +
> +(define* (libiconv-if-needed #:optional (target (%current-target-system)))
> +  (if (mingw-target? target)
> +      `(("libiconv" ,libiconv))
> +      '()))
> +

I am sorry for my ignorance but why is libiconv needed when targeting mingw?

Thanks,
Manolis



reply via email to

[Prev in Thread] Current Thread [Next in Thread]