Re: [PATCH] Add thinkfan.

[Kei Yamashita]

On Sun, 1 May 2016 17:14:18 -0400
Leo Famulari <address@hidden> wrote:

> On Sun, May 01, 2016 at 01:05:59AM +0200, Nicolas Goaziou wrote:
> > * gnu/packages/linux.scm (thinkfan): New variable.  
> 
> Thanks!
> 
> > +    (arguments
> > +     `(#:tests? #f                      ;no test target
> > +       #:configure-flags
> > +       `("-DUSE_ATASMART:BOOL=ON")))  
> 
> Can you add a brief comment explaining this flag?
> 
> Also, can you add a phase that installs the "rcscripts"? They will be
> useful for Guix users on foreign distros.
> 
> I'm not sure where to install them. Since they will probably have to
> be copied or symlinked out of ~/.guix-profile anyways, how about
> installing them into 'share/misc'?
> 
> I'm open to better ideas!
> 
> > +    (synopsis "Simple fan control program")  
> 
> Is it specific to ThinkPads? If so, can you change the synopsis to
> "Simple fan control program for ThinkPads" and mention the limitation
> in the description?
> 

It would be helpful if you told the user where and how to install each
script for each of the major distribution families, similar to how Guix
does this for SystemD and Upstart systems[1].

[1]
https://gnu.org/software/guix/manual/html_node/Binary-Installation.html