[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/10] gnu: readline: support mingw.
|
From: |
Jan Nieuwenhuizen |
|
Subject: |
Re: [PATCH 08/10] gnu: readline: support mingw. |
|
Date: |
Mon, 02 May 2016 21:25:36 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Andy Wingo writes:
>> * gnu/packages/patches/readline-6.3-mingw.patch: New file.
>> * gnu-system.am (dist_patch_DATA): Add it.
>> * gnu/packages/readline.scm (readline): Support mingw.
>
> Can you clarify the licensing on the patch, and note its original
> author? Ideally we should send the patch upstream, too.
Oops, didn't mean to snip this. I mailed Alexey Pavlov and didn't get a
response yet. I found an earlier patch that this seems to add a bit
too.
As you can see, it's #ifdef'ing out macros that are missing on mingw:
S_ISUID, S_ISGID, S_ISLNK, S_ISSOCK.
And now that I look into it, also some that were missing but are now
present: SIGHUP, SIGQUIT. And defining S_ISDIR which is a straight copy
from stat.h, but is now present in mingw too.
Another possibility would be to just patch those macros into mingw's
stat.h and drop this patch. WDYT?
Jan
--
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.nl