Re: [PATCH 06/10] gnu: Add libiconv.

[Ludovic Courtès]

Manolis Ragkousis <address@hidden> skribis:

> On 04/29/2016 06:12 PM, Jan Nieuwenhuizen wrote:
>> +  #:use-module (guix build-system trivial)
>> +  #:export (glibc
>> +            libiconv-if-needed))
>
> The #:export (glibc...) part only exists in wip-hurd so we need to
> remove this in order for your patch to apply on master.

Yes.

>> +(define-public libiconv
>> +  (package
>> +   (name "libiconv")
>> +   (version "1.14")
>> +   (source (origin
>> +            (method url-fetch)
>> +            (uri (string-append
>> +                  "mirror://gnu/libiconv/libiconv-"
>> +                  version ".tar.gz"))
>> +            (sha256
>> +             (base32
>> +              "04q6lgl3kglmmhw59igq1n7v3rp1rpkypl366cy1k1yn2znlvckj"))))
>> +   (build-system gnu-build-system)
>> +   (synopsis "Character set conversion library")
>> +   (description
>> +     "libiconv provides an implementation of the iconv function for systems
>> +that lack it.  iconv is used to convert between character encodings in a
>> +program.  It supports a wide variety of different encodings.")
>> +   (home-page "http://www.gnu.org/software/libiconv/";)
>> +   (license lgpl3+)))
>
> Maybe we should break this patch into two different ones, one for the
> libiconv package description and one for the libiconv-if-needed. The
> first will go to master and the second to core-updates. WDYT?

Seconded: the patch that adds libiconv (and only that) can go directly
in master; the patch that adds ‘libiconv-if-needed’ must be separate
since it depends on the MinGW stuff.

Thanks,
Ludo’.