guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] gnu: Add utfcpp.


From: Leo Famulari
Subject: Re: [PATCH 1/3] gnu: Add utfcpp.
Date: Sat, 7 May 2016 18:19:23 -0400
User-agent: Mutt/1.6.0 (2016-04-01)

On Sat, May 07, 2016 at 01:36:21PM -0500, Alex Griffin wrote:
> This is a dependency of ledger. It's bundled in ledger's source but I
> think it's better to unbundle it. It's a bit unusual in that the headers
> contain the whole source.

> * gnu/packages/unicode.scm: New file.

Not a bad idea for a new module, but I wonder if you considered any of
the existing modules? Are none of them appropriate?

> +(define-public utfcpp

I'm curious — are there any significant differences between this and the
bundled library?

> +              (uri
> +               (string-append 
> "mirror://sourceforge/project/utfcpp/utf8cpp_2x/Release%20"
> +                              version "/utf8_v"
> +                              (string-map (lambda (x) (if (eq? x #\.) #\_ 
> x)) version)
> +                              ".zip"))

Can you make sure these lines are < 80 characters?

Otherwise, LGTM!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]