Re: [PATCH 3/3] gnu: Add emacs-ledger-mode.

[Alex Kost]

Alex Griffin (2016-05-07 21:42 +0300) wrote:

> This is the Emacs mode for manipulating ledger files. Technically it
> depends on ledger but it would have need to be a propagated input, so I
> didn't include that. Maybe I should have? I don't know.

As for me, I think this emacs stuff shouldn't be extracted from 'ledger'
package.  We don't do this for other packages: for example, 'mu' has an
emacs interface (called 'mu4e'); 'asymptote' will have too (discussed in
a separate thread¹); and 'guix' itself has some elisp code.

So I think there is no need to make a separate 'emacs-ledger-mode'
package, but instead 'ledger' package should be adjusted (if needed) to
put elisp files in appropriate place.

> +    (description
> +     "Ledger is a powerful, double-entry accounting system that is
> +     accessed from the UNIX command-line.  This package contains an
> +     Emacs mode for manipulating ledger's text-based file format,
> +     running reports on it, reconciling its accounts, and more.")

I see that you add leading spaces on each line inside your
descriptions.  There is no need to do it, just:

    (description
     "Ledger is a powerful, double-entry accounting system that
is accessed from the UNIX command-line.  This package contains an
Emacs mode for manipulating ledger's text-based file format,
running reports on it, reconciling its accounts, and more.")

¹ http://lists.gnu.org/archive/html/guix-devel/2016-05/msg00206.html

-- 
Alex