Re: [PATCH] entr-3.5

[Ludovic Courtès]

Hello!

Matthew Jordan <address@hidden> skribis:

> Thank you for the welcome Ludovic Courtès. I just have a couple of
> questions.
>
>>   3. Added the file to gnu/local.mk.
>
> Is this file to be updated when a new source file is added?

Yes.

>>   4. Added a ChangeLog-style commit log.
>
> Is there a specific reference/manual on the "ChangeLog-style" I could review?

The manual contains references to the GNU Coding Standards, which
explain it in more detail:

  https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

Otherwise, it’s a good idea to look at the output of ‘git log’ and to
mimic what others do.  :-)

>>   2. Added a ‘remove-fhs-file-names’ phase to remove hard-coded
>>      references to /bin/cat and /usr/bin/clear.
>
> And is ‘remove-fhs-file-names’ a custom phase? If not, which source file
> contains the available phases?

No, it’s a phase I added specifically to this package.  See
gnu/packages/entr.scm.

HTH!

Ludo’.