guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] build: Move included files to subdirectories.


From: Mathieu Lirzin
Subject: Re: [PATCH 1/2] build: Move included files to subdirectories.
Date: Sat, 21 May 2016 23:41:00 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> Mathieu Lirzin <address@hidden> skribis:
>
>> address@hidden (Ludovic Courtès) writes:
>>
>>> Eric Bavier <address@hidden> skribis:
>>>>
>>>> I don't prefer the "local.mk" convention.  It becomes
>>>> non-obvious that the file is input for Automake, and the name loses any
>>>> descriptive power.
>>>
>>> I have mixed feelings (notably because file names in those .mk files
>>> remain relative to $top_srcdir, which can be confusing and will make M-/
>>> useless).
>>
>> I didn't know about M-/ :)
>>
>> To emphasize how the file names relate to the current directory of the
>> ‘Makefile’ snippet, we could use ‘%reldir%’ or ‘%D%’ like describe in:
>>
>>   https://www.gnu.org/software/automake/manual/automake.html#Include
>>
>> Moreover this would makes the future move/rename of directories less
>> troublesome.
>>
>> WDYT?
>
> Hey, didn’t know about that one!  :-)
>
> So yes, %D%, why not?
>
> Ludo’.

Do you confirm?

Attachment: 0001-build-Use-D-in-Makefile-fragments.patch
Description: Text Data

I give another chance for others to disagree.  :)

-- 
Mathieu Lirzin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]